Disable beta packages tests on Debian #316
Conversation
These packages are currently not available.
|
Sooo… Grafana from 2019 (6.0.0) does not play well with Debian from 2021 (11.0). Maybe time to drop older versions from testing. |
The last 7.x release was ~6 month ago and basically correspond to the beginning of availability of version 9.x. 7.x not being updated anymore, we can drop it (and older versions) with the benefit of speeding-up the acceptance test suite. While here, bump the version of the older releases which are older than the operating systems we support and where sometimes not compatible. Do not do this for 9.x because we also test with 'latest'.
|
Requesting another review since I changed quite a bit since your review @bastelfreak 😉 |
| it 'works idempotently with no errors' do | ||
| case fact('os.family') | ||
| when 'Debian' | ||
| # As of 2023-03-22, Debian beta packages are non functinal and disabled |
There was a problem hiding this comment.
the whole case block doesnt make sense. we could also drop it.
There was a problem hiding this comment.
The code duplication is somewhat recent in the code history.
At first I wanted to revert the part that made both snippets identical, but the grafana repos are really missing packages, so even with explicit versions it would probably not work on the long term (only 2 beta packages are available in the Debian repo).
My guess was that this is currently broken on the Grafana side and might be fixed in the future, and maybe we will want to test it again when it is fixed. For this reason I just drop that comment and did not touched the rest.
If we assume we do not care about beta releases on Debian, we can simplify this, but I am not a heavy user of Grafana so can't tell if it is likely to be fixed one day or not.
I am fine with both options and don't have an opinion, so will follow what other people have to say in regard to this.
These packages are currently not available.
Also include: