Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: icingaweb2::config::resource 'port' requires an integer, not a string #231

Merged
merged 2 commits into from
May 17, 2019
Merged

Docs: icingaweb2::config::resource 'port' requires an integer, not a string #231

merged 2 commits into from
May 17, 2019

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Apr 17, 2019 •
edited
Loading

Got that while implementing a custom resource for reporting while following the docs.

@dnsmichi dnsmichi requested a review from lbetz April 17, 2019 09:03
@lazyfrosch lazyfrosch self-assigned this May 17, 2019
@lazyfrosch lazyfrosch added the bug label May 17, 2019
@lazyfrosch lazyfrosch added this to the v2.3.0 milestone May 17, 2019
lazyfrosch
lazyfrosch approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@lazyfrosch lazyfrosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I fixed another case in examples

@lazyfrosch lazyfrosch merged commit d0849d1 into master May 17, 2019
@lazyfrosch lazyfrosch deleted the bugfix/docs-config-resource-port branch May 17, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazyfrosch lazyfrosch lazyfrosch approved these changes

@lbetz lbetz Awaiting requested review from lbetz

Assignees

@lazyfrosch lazyfrosch

Labels
bug
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dnsmichi @lazyfrosch