Moving away from templates to usign inifile from Puppetlabs/inifile

[smbambling]

This give extra flexibility when adding multiple resources or authentication types. You can just call the define in your profile manifest.

[arioch]

Please update your stdlib and revert this line. ;)

puppetlabs/puppetlabs-stdlib@bf8e5b0

[smbambling]

The update to move to assert_private is extremely new and not included in even the newest release 4.5.1 (https://github.com/puppetlabs/puppetlabs-stdlib/tree/4.5.1). You would be required to run off the latest release or specific commit you listed above. This might limit users from being able to utilize this module, would you be ok with having it set with private() for now and updating once a new version of stdlib is cut ?

[arioch]

You can also use is_function_available('assert_private') to support both.
It's in stdlib as well.

[smbambling]

I updated to support both as requested

[arioch]

Thanks for the contribution.
If you could you add spec tests I can review and merge it.

[smbambling]

I unfortunately don't have any experience with writing spec tests, though my changes didn't introduce any new parameters or logic that shouldn't ( from what I gather looking at the current tests ) break or invalidate the current spec tests.

Is there something specific that you would request be added ?

[smbambling]

Is there any comments you can provide or changes you think need made?

[arioch]

Unbreaking the tests would be an excellent start to get it merged. :)

$ bundle exec rake spec
Finished in 7.72 seconds (files took 0.60074 seconds to load)
77 examples, 71 failures, 6 pending

[smbambling]

Well that definitely doesn't look good :), I'll try to do some reading up on rspec this week so I can debug what is making the tests fail. I'm able to manually test this with puppet apply on a host and it works, my changes must have introduced something that is making the tests freak out

[arioch]

Judging by the looks of your code I'm quite confident it works flawlessly. 👍
I could try to add the tests myself to help you out, but I don't see it happen within a week given my current time schedule.

[smbambling]

Any help would be appreciated, no rush as IcingaWeb2 is still in beta and we are not actively using this module in any production environment. I was just doing some testing and wanted to give back my changes.

[ckaenzig]

@smbambling You first have to add a dependency on the puppetlabs-inifile module in the .fixtures.yml file:

diff --git a/.fixtures.yml b/.fixtures.yml
index a0ee02e..5e61be1 100644
--- a/.fixtures.yml
+++ b/.fixtures.yml
@@ -2,6 +2,7 @@ fixtures:
   repositories:
     apache:  'git://github.com/puppetlabs/puppetlabs-apache.git'
     concat:  'git://github.com/puppetlabs/puppetlabs-concat.git'
+    inifile: 'git://github.com/puppetlabs/puppetlabs-inifile.git'
     stdlib:  'git://github.com/puppetlabs/puppetlabs-stdlib.git'
     vcsrepo: 'git://github.com/puppetlabs/puppetlabs-vcsrepo.git'

Then they start showing a useful error:

     Puppet::Error:
       Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type icingaweb2::config::database at puppet-icingaweb2/spec/fixtures/modules/icingaweb2/manifests/config.pp:112

I don't see any icingaweb2::config::database defined type in our code. Have you perhaps forgot to add some file to the commit?

[smbambling]

I found some typos with the resource defines and them being called in config.pp. I also added the update to the .fixtures.yml file you stated.

Now I can see some some detailed errors.

Finished in 7.76 seconds (files took 0.47417 seconds to load)
77 examples, 24 failures, 6 pending

[arioch]

Looks good so far. 👍
I still need to take a look at the 24 failing tests though.

[arioch]

Fixing those failing tests right now. :)

[arioch]

Merged upstream!

[smbambling]

awesome thanks @arioch