Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for removing jenkins plugin #10

Open
php-coder opened this issue Jul 5, 2013 · 5 comments
Open

Add ability for removing jenkins plugin #10

php-coder opened this issue Jul 5, 2013 · 5 comments
Labels
enhancement New feature or request

Comments

@php-coder
Copy link
Contributor

Please provide ability to remove installed plugin. I suggest the following syntax:

class { 'jenkins':                                                                                  
  plugin_hash => {
    'cvs' => { version => 'absent' }
  }
}
@matthewbarr
Copy link
Contributor

Right now this isn't implemented at all and would be a bad idea to do blindly.
If you remove a plugin manually, jobs that require that plugin might disappear.

We're looking into using a puppet package provider for Jenkins, but I've got limited time to work on it right now.

Similar to #11 , the remote CLI doesn't allow for removal at all. It might be possible via Groovy. Still not sure what will happen if the job requires a plugin and it's gone. This may allow you to break your Jenkins install.

@rtyler
Copy link

rtyler commented Jul 5, 2013

@php-coder In your mind, should version => absent cause the .jpi file to be removed, should the entries in the config.xml file be removed, and/or should plugin specific settings files be removed as well?

I think @matthewbarr is correct in that removing a plugin might break jobs, but this is no different than unchecking the plugin box in the Plugin Manager (as far as I know).

That said, you reference the "cvs" plugin, which is (IIRC) still a core plugin which can't actually be removed.

@php-coder
Copy link
Contributor Author

@rtyler I expect that plugin removal from puppet works exactly as unchecking the plugin box in the Plugin Manager. Removal of "cvs" plugin was not appropriate example, because it belongs to core, but Plugin Manager allows to deselect it.

matthewbarr added a commit that referenced this issue Oct 10, 2013
fix spec tests, repo functionality revert,
@rtyler rtyler added this to the 1.1.0 Duckworth milestone Feb 24, 2014
@rtyler
Copy link

rtyler commented Apr 1, 2014

@php-coder I can't actually find any indication that disabling a plugin affects anything on disk. An ensure => absent should remove the plugin IMHO, similar to what the "uninstall" button in the UI does.

I think I might punt on ensure => disabled until such a time that I can see what Jenkins does on disk when you check that box.

rtyler pushed a commit that referenced this issue Apr 24, 2014
@rtyler rtyler modified the milestones: 1.2.0: Nestor, 1.1.0 Duckworth Apr 26, 2014
@rtyler rtyler modified the milestone: 1.2.0: Nestor Sep 25, 2014
jgreen210 pushed a commit to jgreen210/puppet-jenkins that referenced this issue Jun 16, 2017
@ekohl
Copy link
Member

ekohl commented Sep 3, 2020

The code suggests there is code to ensure disabled. You can also purge all plugins, but not ensure absent today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants