-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to a standardized Java requirement..? #18
Comments
I looked at the java module a while back, is it "good" now? Before it was pretty crap for non-RHEL hosts (and non-Oracle JRE) |
Well, it looks like they've made it non oracle specific, using OS packages that should be available. OpenJDK for the most part. It covers RHEL/Centos/OracleLinux, Fedora, Amazon, and then various Debian/Ubuntu's, and then solaris & suse. https://github.com/puppetlabs/puppetlabs-java/blob/master/manifests/params.pp Seems pretty decent to me, it's just basically a way to pick the right java JDK package name mostly... No execs or downloads outside of the existing package mgmt systems. |
Sounds good to me |
Looks like this is being done in #24 I'll see about adding the dependency to the code.. |
Updated Gemfile and put the puppet_blacksmith and metadata-json-lint gems into a group that will be ignored by travis-ci. These gems aren't used in the tests anyway. Updated Rakefile to only load puppet_blacksmith if the module is already defined.
Updated Gemfile and put the puppet_blacksmith and metadata-json-lint gems into a group that will be ignored by travis-ci. These gems aren't used in the tests anyway. Updated Rakefile to only load puppet_blacksmith if the module is already defined.
Do we want to switch to using the puppetlabs java module, to deal w/ the requirement for java?
We already duplicate (poorly) some of the code in the slave manifest, and this would solve more OS issues by abstracting them out. Not to mention, reduce the possibility of another module requiring the same java package, and having a failure because of it.
https://forge.puppetlabs.com/puppetlabs/java
@rtyler , anyone else... thoughts?
The text was updated successfully, but these errors were encountered: