Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to a standardized Java requirement..? #18

Closed
matthewbarr opened this issue Aug 8, 2013 · 4 comments
Closed

Switching to a standardized Java requirement..? #18

matthewbarr opened this issue Aug 8, 2013 · 4 comments
Labels
enhancement New feature or request

Comments

@matthewbarr
Copy link
Contributor

Do we want to switch to using the puppetlabs java module, to deal w/ the requirement for java?

We already duplicate (poorly) some of the code in the slave manifest, and this would solve more OS issues by abstracting them out. Not to mention, reduce the possibility of another module requiring the same java package, and having a failure because of it.

https://forge.puppetlabs.com/puppetlabs/java

@rtyler , anyone else... thoughts?
@rtyler
Copy link

rtyler commented Aug 8, 2013

I looked at the java module a while back, is it "good" now? Before it was pretty crap for non-RHEL hosts (and non-Oracle JRE)

@matthewbarr
Copy link
Contributor Author

Well, it looks like they've made it non oracle specific, using OS packages that should be available. OpenJDK for the most part.

It covers RHEL/Centos/OracleLinux, Fedora, Amazon, and then various Debian/Ubuntu's, and then solaris & suse.

https://github.com/puppetlabs/puppetlabs-java/blob/master/manifests/params.pp

Seems pretty decent to me, it's just basically a way to pick the right java JDK package name mostly... No execs or downloads outside of the existing package mgmt systems.

@rtyler
Copy link

rtyler commented Aug 8, 2013

Sounds good to me

@matthewbarr
Copy link
Contributor Author

Looks like this is being done in #24 I'll see about adding the dependency to the code..

@tmclaugh tmclaugh mentioned this issue Aug 24, 2013
Closed
jgreen210 pushed a commit to jgreen210/puppet-jenkins that referenced this issue Jun 16, 2017
Update Gemfile and Rakefile fix tests PR voxpupuli#18
58539a8 
Updated Gemfile and put the puppet_blacksmith and metadata-json-lint
gems into a group that will be ignored by travis-ci. These gems aren't
used in the tests anyway.

Updated Rakefile to only load puppet_blacksmith if the module is already
defined.
jgreen210 pushed a commit to jgreen210/puppet-jenkins that referenced this issue Jun 16, 2017
Update Gemfile and Rakefile fix tests PR voxpupuli#18
f1e4dd4 
    Updated Gemfile and put the puppet_blacksmith and metadata-json-lint
    gems into a group that will be ignored by travis-ci. These gems aren't
    used in the tests anyway.

    Updated Rakefile to only load puppet_blacksmith if the module is already
    defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtyler @matthewbarr