Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple arguments in JENKINS_ARGS separated by spaces #1033

Closed

Conversation

sbeaulie
Copy link

Pull Request (PR) description

before this change setting mutiple arguments like --sessionTimeout=480 --sessionEviction=28800
would fail when starting jenkins with errors similar to java.lang.NumberFormatException: For input string: "480 --sessionEviction=28800"
this means we need to separate each arg and load them separately in the PARAMS bash array

This Pull Request (PR) fixes the following issues

N/A

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole jenkins-run is no longer needed and shipped by the latest jenkins version (which includes the systemd unit file as well). I think it'd be better to make sure that can be used instead.

before this change setting mutiple arguments like --sessionTimeout=480 --sessionEviction=28800
would fail when starting jenkins with errors similar to java.lang.NumberFormatException: For input string: "480 --sessionEviction=28800"
this means we need to separate each arg and load them separately in the PARAMS bash array
@ekohl
Copy link
Member

ekohl commented May 3, 2022

Made obsolete by #1035

@ekohl ekohl closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants