Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-in file systemd configuration #1044

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

jan-win1993
Copy link

Pull Request (PR) description

Currently the Systemd drop-in file can only override environment variables.
I would like to expand this functionality to make it possible to override every configuration in the [Service] section of the drop-in file.

This Pull Request (PR) fixes the following issues

Fixes #1009

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all tests fail. I'm not sure if that's related.

manifests/init.pp Outdated Show resolved Hide resolved
templates/jenkins-override.epp Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented May 20, 2022

Please rebase. I just merged #1041 which means the tests should be green.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test for this. Either a unit test or an acceptance test (note that's an or, not an xor).

templates/jenkins-override.epp Outdated Show resolved Hide resolved
templates/jenkins-override.epp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I just wonder if the test failures are related or my fixes were insufficient. I've opened #1045 which should give some answers.

@ekohl
Copy link
Member

ekohl commented Jun 1, 2022

That also failed so I'm merging this now and get back to fixing the tests later.

@ekohl ekohl merged commit ebdfc35 into voxpupuli:master Jun 1, 2022
@ekohl ekohl added the enhancement New feature or request label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to set the open files limit in systemd service
2 participants