-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop-in file systemd configuration #1044
Conversation
996bd6f
to
010953d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like all tests fail. I'm not sure if that's related.
Please rebase. I just merged #1041 which means the tests should be green. |
010953d
to
2b8d3e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a test for this. Either a unit test or an acceptance test (note that's an or
, not an xor
).
2b8d3e4
to
5dafd74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. I just wonder if the test failures are related or my fixes were insufficient. I've opened #1045 which should give some answers.
That also failed so I'm merging this now and get back to fixing the tests later. |
Pull Request (PR) description
Currently the Systemd drop-in file can only override environment variables.
I would like to expand this functionality to make it possible to override every configuration in the [Service] section of the drop-in file.
This Pull Request (PR) fixes the following issues
Fixes #1009