Fix Plugin Download Timeout #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When downloading large plugins, it can timeout (e.g. ruby-runtime). The archive::download supports a timeout value which defaults to 120 seconds, but this plugin class doesn’t have any support to override this value. This allows for the ability to adjust the timeout value for large plugins. Error message when download timeout exceeds 120 seconds: Error: /Stage[main]/Jenkins::Plugins/Jenkins::Plugin[ruby-runtime]/Archive::Dow nload[ruby-runtime.hpi]/Exec[download archive ruby-runtime.hpi and check sum]/returns: change from notrun to 0 failed: Command exceeded timeout
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I'm going to go ahead and merge this and add the rspec-puppet necessary myself |
rtyler
pushed a commit
to rtyler/puppet-jenkins
that referenced
this pull request
Nov 7, 2015
…meout => 1) works References voxpupuli#419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading large plugins, it can timeout (e.g. ruby-runtime). The
archive::download supports a timeout value which defaults to 120
seconds, but this plugin class doesn’t have any support to override
this value. This allows for the ability to adjust the timeout value for
large plugins.
Error message when download timeout exceeds 120 seconds:
Error:
/Stage[main]/Jenkins::Plugins/Jenkins::Plugin[ruby-runtime]/Archive::Dow
nload[ruby-runtime.hpi]/Exec[download archive ruby-runtime.hpi and
check sum]/returns: change from notrun to 0 failed: Command exceeded
timeout