fix plugin install logic matching #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
force-pushed
the
bug/plugin-name-version-matching
branch
from
ea78e96
to
0ddaaf5
Compare
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
It was possible for a plugin to fail to be installed if it's name and version matched as a substring of an already installed plugin. Which means that a test for `credentials 1.12` could potentially match on an incorrect plugin name such as `ssh-credentials 1.12`. resolves voxpupuli#513
jhoblitt
force-pushed
the
bug/plugin-name-version-matching
branch
from
0ddaaf5
to
89ce1a8
Compare
rtyler
pushed a commit
that referenced
this pull request
Mar 3, 2016
fix plugin install logic matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible for a plugin to fail to be installed if it's name and
version matched as a substring of an already installed plugin. Which
means that a test for
credentials 1.12could potentially match on anincorrect plugin name such as
ssh-credentials 1.12.resolves #513