Disable swarm unique id on slave #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've restarted the failed travis job. It looks like the build slave went away mid-output. |
rtyler
requested changes
Oct 12, 2016
| @@ -60,6 +60,7 @@ JENKINS_USERNAME=<%= @quoted_ui_user %> | |||
| JENKINS_PASSWORD=<%= @quoted_ui_pass %> | |||
|
|
|||
| OTHER_ARGS="<%= '-disableSslVerification' if @disable_ssl_verification -%>" | |||
| DISABLE_UNIQUE="<%= '-disableClientsUniqueId' if @disable_ssl_verification-%>" | |||
There was a problem hiding this comment.
I believe this is using the wrong variable in the ERB template. Instead of disable_ssl_verification it should be disable_clients_unique_id
mterzo
force-pushed
the
disable_client_id
branch
from
ac9c915
to
a43ffd8
Compare
rtyler
approved these changes
Oct 12, 2016
|
With #655 this may not be necessary anymore, but I don't think having an explicit option is necessarily a bad thing so I'm going to mergeymerge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI broke on older ruby, net-http-persistent 3.0 requires ruby 2.1, adding this change as well.