Add support for conduit credentials #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 7, 2017 16:27
Conduit credentials are needed to integrate jenkins with phabricator.
jhoblitt
approved these changes
Mar 7, 2017
|
I'm not familiar with the conduit credential type. Is this from the phabricator plugin? |
|
Yes, conduit is the HTTP API for phabricator that has its own credentials type that is used by Uber's phabricator plugin for jenkins. |
|
@jhoblitt the CI seems to be broken on master. I don't think that this PR causes any regressions in CI. Any chance of a merge, pls :D |
|
Hey @jhoblitt! Are you happy with this PR? If so, is there any chance of a merge pls? |
|
Sure ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed for jenkins to integrate with the phabricator plugin.