Fix incorrect syntax in acceptance tests #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
disable-plugin-acceptance-tests
branch
2 times, most recently
from
db12d24
to
56f2dae
Compare
bastelfreak
approved these changes
Mar 12, 2020
ekohl
changed the title
This comment has been minimized.
This comment has been minimized.
These plugins are also in the default plugins so don't need to be defined again.
ekohl
force-pushed
the
disable-plugin-acceptance-tests
branch
from
56f2dae
to
8a60f99
Compare
ekohl
changed the title
|
Still fails, but these are at least improvements to make Puppet catalogs compile so merging. |
ekohl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix all tests, but at least brings us a bit closer to working builds.