Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eval in jenkins-run #968

Closed
wants to merge 1 commit into from
Closed

Use eval in jenkins-run #968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/jenkins-run.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,4 @@ if [ "$JENKINS_ENABLE_ACCESS_LOG" = "yes" ]; then
PARAMS+=("--simpleAccessLogger.file=/var/log/jenkins/access_log")
fi

$JAVA_CMD "${PARAMS[@]}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is my understanding that this way of using bash arrays actually should have the proper quotes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not about quotes in PARAMS array, it's about quotes in JENKINS_JAVA_CMD , JENKINS_JAVA_OPTIONS, JENKINS_HOME or JENKINS_WAR.

eval "$JAVA_CMD ${PARAMS[@]}"