Puppet 4.0 support #106
Closed
Puppet 4.0 support #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: metadata.json
# Conflicts: # metadata.json
| @@ -26,11 +26,11 @@ | |||
| "requirements": [ | |||
| { | |||
| "name": "pe", | |||
| "version_requirement": ">=3.7.0 <4.0.0" | |||
| "version_requirement": ">=3.7.0 <4.3.0" | |||
There was a problem hiding this comment.
4.3.0 was just released, is there a particular reason to stay below that version when testing?
There was a problem hiding this comment.
pretty sure we can do <5.0.0 here
|
I don't have any technical comments but did add a few syntax comments. Also see #96 (comment), same failures are occuring here. |
Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
FIX linting
The format parameter needs to not have a leading . or all of the spec tests need to be fixed to pass it in. As removing it is the simpler option this does that. Secondly, the calculated file names for the deploy need to have the file extension . added. Also, the calculated file name for pre-7.0.0 had been destroyed, this puts it back to what it should be. Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
Merged
Fix deployment files to unblock spec
|
Hello: What's the status of this PR? |
|
@ffquintella can we convince you to rebase & squash this pr? |
|
Igalic. For me it's ok. I will close de PR. And as soon as I have some extra time I will watch into rebasing |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a new version with some minor bugfixes