added a "bin_dir" parameter to configure where the Kafka scripts are #147
Conversation
|
Hi @LionelCons, thanks for the PR and sorry for the low response :( |
| @@ -12,6 +12,7 @@ | |||
| $scala_version = '2.11' | |||
| $install_dir = "/opt/kafka-${scala_version}-${version}" | |||
| $config_dir = '/opt/kafka/config' | |||
| $bin_dir = '/opt/kafka/bin' | |||
There was a problem hiding this comment.
Since we're on puppet4 (or even 5 \o/) now, can you please use the datatype Stdlib::Absolutepath here (and in the other classes where you use the $bin_dir)?
|
@bastelfreak I've tried to rebase from upstream but got problems. My current master is now OK and should not give merge conflicts. Please check if this works or if I should create a new PR. Regarding types, it would probably make sense to change them all (all the |
|
Hi @LionelCons, it seems like there are still merge conflicts, and you probably merged our master into your branch, instead of rebasing? Could you try again to rebase? If you've any questions feel free to join our IRC channel. We're happy to help you out with git. |
|
I gave up and started again from scratch. You can drop this PR and consider #159 instead. |
This fixes #145.