added a "bin_dir" parameter to configure where the Kafka scripts are #159
Conversation
manifests/broker.pp
Outdated
| @@ -69,6 +72,7 @@ | |||
| $group_id = $kafka::params::group_id, | |||
| $user_id = $kafka::params::user_id, | |||
| $config_dir = $kafka::params::config_dir, | |||
| $bin_dir = $kafka::params::bin_dir, | |||
There was a problem hiding this comment.
@LionelCons can you use the datatype Stdlib::Absolutepath here and in all other locations where you use the new parameter?
There was a problem hiding this comment.
@bastelfreak It would probably make sense to change all the $*_dir variables at once. Currently, $bin_dir is defined and used exactly like $config_dir.
There was a problem hiding this comment.
of course you can change all of them. But I want to have datatypes at least for all new parameters.
|
This fixes #145 |
|
This replaces #147 |
manifests/broker/service.pp
Outdated
| @@ -17,6 +17,7 @@ | |||
| $heap_opts = $kafka::broker::heap_opts, | |||
| $opts = $kafka::broker::opts, | |||
| $config_dir = $kafka::broker::config_dir, | |||
| $bin_dir = $kafka::broker::bin_dir, | |||
There was a problem hiding this comment.
we need "Stdlib::Absolutepath " here as well
manifests/mirror/service.pp
Outdated
| @@ -18,6 +18,7 @@ | |||
| $blacklist = $kafka::mirror::blacklist, | |||
| $max_heap = $kafka::mirror::max_heap, | |||
| $config_dir = $kafka::params::config_dir, | |||
| $bin_dir = $kafka::params::bin_dir, | |||
There was a problem hiding this comment.
we need "Stdlib::Absolutepath " here as well
manifests/consumer/service.pp
Outdated
| @@ -12,6 +12,7 @@ | |||
| $service_defaults = $kafka::consumer::service_defaults, | |||
| $service_requires_zookeeper = $kafka::consumer::service_requires_zookeeper, | |||
| $limit_nofile = $kafka::consumer::limit_nofile, | |||
| $bin_dir = $kafka::consumer::bin_dir, | |||
There was a problem hiding this comment.
we need "Stdlib::Absolutepath " here as well
| @@ -18,6 +18,7 @@ | |||
| $scala_version = '2.11' | |||
| $install_dir = "/opt/kafka-${scala_version}-${version}" | |||
| $config_dir = '/opt/kafka/config' | |||
| $bin_dir = '/opt/kafka/bin' | |||
There was a problem hiding this comment.
we need "Stdlib::Absolutepath " here as well
manifests/producer/service.pp
Outdated
| @@ -12,6 +12,7 @@ | |||
| $service_config = $kafka::producer::service_config, | |||
| $service_defaults = $kafka::producer::service_defaults, | |||
| $service_requires_zookeeper = $kafka::producer::service_requires_zookeeper, | |||
| $bin_dir = $kafka::producer::bin_dir, | |||
There was a problem hiding this comment.
we need "Stdlib::Absolutepath " here as well
|
@bastelfreak I've done for Compare for instance with |
|
Hi @LionelCons, |
|
@bastelfreak I've added the type even for private classes. IMHO, there are solutions to simplify the classes and parameters but let's discuss this elsewhere. Please accept this PR so that we can move forward. |
|
@LionelCons let me know if you need this in a release, we can kick it of pretty quickly. |
|
@bastelfreak In fact, there are several things that we would need to get fixed/improved. So no need for a new release now... |
add a "bin_dir" parameter to configure where the Kafka scripts are
Follow-up from PR#147...