Fix classes broker::consumer and broker::producer #46
Conversation
|
could you add a note to the README.md that a major release is required the next time? |
|
@bastelfreak I will do the next release myself, but I am not sure if I should do this before or after adding the support for Kafka 0.9. |
| @@ -23,12 +25,12 @@ | |||
| } | |||
|
|
|||
| file { '/opt/kafka/config/server.properties': | |||
| ensure => present, | |||
There was a problem hiding this comment.
This is not necessary and we do not use it for our other modules.
https://docs.puppetlabs.com/puppet/latest/reference/type.html#file-attribute-ensure
There was a problem hiding this comment.
i thought puppet-lint would complain…
There was a problem hiding this comment.
No that was about the broken class mirror. I also should update my RVM environment. ;)
* Add missing equal sign * Fix process name * Ignore empty parameters
* Fix dependencies * Fix file permissions * Notify correct service
* Add config, config_defaults * Add service_config, service_defaults
|
nicely done. are you ready for merge, or do you want to pretty up your commit history? |
|
IMO the history is fine, nicely seperated small commits |
|
Give me some time to clear my head. In the meantime I will run some Beaker tests to make sure the configs and init scripts are still generated correctly. If this is working as expected, I will add the spec files for the Beaker tests as a separate PR. |
|
👍 |
|
👍 |
Fix classes broker::consumer and broker::producer
Fix classes broker::consumer and broker::producer
I am writing a couple of beaker tests and came across the following problems:
The generated Inits Scripts were broken because of
The file resource did not notified the correct service and the config parameters for properties file or Init Script should be managed at the main class.
I know that this would force a major release, but on the other hand this part of the Kafka module could not have worked before.