Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for native_ipv6 in vrrp instances #184

Merged
merged 7 commits into from
Jun 9, 2019

Conversation

sigbjorntux
Copy link
Contributor

This pull request Fixes #183

@bastelfreak bastelfreak added the enhancement New feature or request label Jun 8, 2019
@bastelfreak
Copy link
Member

Hi @sigbjorntux, thanks for the PR, can you please add a test for it and document it in the README.md?

@sigbjorntux
Copy link
Contributor Author

Hi @sigbjorntux, thanks for the PR, can you please add a test for it and document it in the README.md?

Hi @bastelfreak. If you want me to update the README.md I assume you are looking for an example with a mixed ipv4/ipv6 instance configuration in a sync group, in a new section?

For the test I would need some guidance. Please let me know if my last commit 2780bf9 would be sufficient.

@bastelfreak
Copy link
Member

Hi. the test looks fine. It's helpful when a parameter is documented in the readme. A working example is even better.

@sigbjorntux
Copy link
Contributor Author

Hi. the test looks fine. It's helpful when a parameter is documented in the readme. A working example is even better.

Ok. I will look into a README example.

Travis does not seem to agree with the test being ok. Any idea what might be wrong?

@sigbjorntux
Copy link
Contributor Author

Adding the config option global_tracking to sync_groups. This allows health checks for vrrp instances to continue working when they are added to a sync_group, which is needed when having VI for both ipv4 and ipv6 addresses.

@sigbjorntux
Copy link
Contributor Author

Hi @bastelfreak, a documentation example has been provided. Please review and merge. Thanks.

@bastelfreak bastelfreak merged commit 16f5406 into voxpupuli:master Jun 9, 2019
@bastelfreak
Copy link
Member

Thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for "native_ipv6" vrrp_instance statement
2 participants