Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mh lb_algo #260

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Add support for mh lb_algo #260

merged 3 commits into from
Feb 25, 2022

Conversation

MrFreezeex
Copy link
Contributor

@MrFreezeex MrFreezeex commented Feb 22, 2022

Signed-off-by: Arthur Outhenin-Chalandre arthur.outhenin-chalandre@cern.ch

Pull Request (PR) description

Add support for mh lb_algo, also add related mh_port and mh_fallback similarly to sh_port and sh_fallback.

This Pull Request (PR) fixes the following issues

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
@MrFreezeex MrFreezeex changed the title Add mh_port and mh_fallback Add support for mh lb_algo Feb 24, 2022
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as someone who has zero experience with keepalived is concerned.

The module lacks a lot of documentation, I suggest adding some for these new parameters. I copied these from the man page available at https://man.archlinux.org/man/keepalived.conf.5.en but fill free to rephrase for better description 😉

manifests/lvs/virtual_server.pp Show resolved Hide resolved
manifests/lvs/virtual_server.pp Show resolved Hide resolved
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
@MrFreezeex
Copy link
Contributor Author

Looks good as far as someone who has zero experience with keepalived is concerned.

The module lacks a lot of documentation, I suggest adding some for these new parameters. I copied these from the man page available at https://man.archlinux.org/man/keepalived.conf.5.en but fill free to rephrase for better description wink

Thanks for the suggestion I also added those for the sh options in a separated commit!

@bastelfreak bastelfreak added the enhancement New feature or request label Feb 25, 2022
@bastelfreak bastelfreak merged commit 4c99c2f into voxpupuli:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants