Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#178 Add single quote around all domains names in shell commands #179

Merged
merged 1 commit into from
Mar 27, 2019
Merged

#178 Add single quote around all domains names in shell commands #179

merged 1 commit into from
Mar 27, 2019

Conversation

Turgon37
Copy link
Contributor

@Turgon37 Turgon37 commented Mar 5, 2019

Pull Request (PR) description

Add single quotes around dns domain name in shell command to prevent shell globbing

This Pull Request (PR) fixes the following issues

Fixes #178

@dhoppe
Copy link
Member

dhoppe commented Mar 6, 2019

@Turgon37 Please update the RSpec tests aswell.

@bastelfreak bastelfreak added bug Something isn't working tests-fail labels Mar 7, 2019
@alexjfisher
Copy link
Member

@Turgon37 Do you need some help with the spec tests?

@Turgon37
Copy link
Contributor Author

Hello @alexjfisher , Thanks to you for your help proposal but I think I will get there.
Just after this PR's creation I've seen that your module is well written with rspec. But as I cannot test on my local computer I searched to test at my work, and for now I've not found the time to do it.

So I will try here

@Rathios
Copy link
Contributor

Rathios commented Mar 25, 2019

I ran into the same problem and tested out the fixes locally. Take a look at Rathios@4953fac, there's probably some more quote fixes to pick out.

@Turgon37
Copy link
Contributor Author

Turgon37 commented Mar 25, 2019

Oh, I think it's ok :)

@Rathios
Copy link
Contributor

Rathios commented Mar 26, 2019

Tested it here too and it works perfectly. 👍 @alexjfisher

@alexjfisher alexjfisher merged commit 3346538 into voxpupuli:master Mar 27, 2019
@alexjfisher
Copy link
Member

@Turgon37 Thanks!

@Turgon37
Copy link
Contributor Author

Thanks to you, I use this module at work and it allow us to save money by using free certs for non production environment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain wildcard should be escaped or quoted in shell commands
5 participants