Remove environment parameter from cron resource #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crontab environment variables are global and we do not as a matter of best practice want to leak environment variables into other cron jobs. We still want to ensure the correct ruby is used to instantiate the refresh-mcollective-metadata script but we can accomplish this by templatizing the shebang line rather than relying on environment variables in the crontab. Closes voxpupuli#207
reidmv
force-pushed
the
207_fix_cron_environment
branch
from
adcca31
to
0bbe0f9
Compare
nibalizer
added a commit
that referenced
this pull request
Jun 5, 2015
Remove environment parameter from cron resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crontab environment variables are global and we do not as a matter of
best practice want to leak environment variables into other cron jobs.
We still want to ensure the correct ruby is used to instantiate the
refresh-mcollective-metadata script but we can accomplish this by
templatizing the shebang line rather than relying on environment
variables in the crontab.
Closes #207