Fix for server_password management #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
server_password-fix
branch
2 times, most recently
from
65f1f33
to
bdfa2dc
Compare
smortex
force-pushed
the
server_password-fix
branch
3 times, most recently
from
c9e6011
to
7d0adb6
Compare
ghoneycutt
approved these changes
Jan 21, 2020
smortex
force-pushed
the
server_password-fix
branch
from
7d0adb6
to
8f31f8d
Compare
The fix provided by voxpupuli#53 is incomplete: using shell redirections and control operators need to switch to the 'shell' exec provider, which in turn allows command injections. Moreover, as explained in voxpupuli#52, murmurd exists with an exit code of 1 on success… but also on failure. Attempt to improve the situation by switching to the shell provider, shell escaping the password thanks to stdlib's shell_escape function, and grep the stderr output of murmurd for a success message.
smortex
force-pushed
the
server_password-fix
branch
from
8f31f8d
to
d90e2da
Compare
|
Looks like I added the stdlib requirements to the wrong section in metadata.json (requirements instead of dependencies)… I just pushed a fix! |
ghoneycutt
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The fix provided by #53 is incomplete: using shell redirections and control operators need to switch to the 'shell' exec provider, which in turn allows command injections. Moreover, as explained in #52, murmurd exists with an exit code of 1 on success… but also on failure.
Attempt to improve the situation by switching to the shell provider, shell escaping the password thanks to stdlib's shell_escape function, and grep the stderr output of murmurd for a success message.
This Pull Request (PR) fixes the following issues
n/a