Multiple 'up' lines in options hash

[saz]

Debian allows multiple 'up' lines in iface stanza. They will be executed in the order written to the file.

But this isn't possible as there can only be one key in the options hash.

[adrienthebo]

My idea for implementing this was to allow up to take an array, within the options hash, like so:

network_config { 'eth0':
  ensure => present,
  options => {
    up => [
      '/sbin/route add net 10.20.30.40/24 via eth0',
      '/sbin/route add net 10.30.50.70/24 via eth0',
      [etc]
    ]
}

Is this an acceptable solution?

[saz]

Looks good to me.

[vjanelle]

Just strictly speaking, there is an file(/etc/sysconfig/static-routes) that manages routes - is this in the scope of this module as well?

[adrienthebo]

@saz I have a topic branch that should have the necessary work to support multiple options in a hash. It passes my unit tests but I don't have the bandwidth to do a lot of acceptance testing on it right now. The branch is at https://github.com/adrienthebo/puppet-network/tree/reimplement_debian_parsing ; would you be willing to test it and see if it works as expected?

[adrienthebo]

@vjanelle So the situation with static routing configuration is really messy right now. I plan on implementing some sort of static route management, but on Debian it's all but impossible to extract routing and interface configuration. On Redhat it's easier since there are the individual route files as you mention, but the problem I have run into is how to manage the data. If I create a new ticket regarding route configuration with a request for comments on how people want to see it implemented would you be willing to toss you input into that?

[vjanelle]

Sure.

[adrienthebo]

@vjanelle I've made #20 , feedback on that would be much appreciated!

[adrienthebo]

Released in 0.3.0-rc1