fix "absent" options #161
Merged
fix "absent" options #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogous to redhat, we check if options are absent, before appending them to the file. This fixes #160
| @@ -91,7 +91,8 @@ def self.format_file(_filename, providers) | |||
| raise Puppet::Error, "#{provider.name} is missing the required parameter 'gateway'." if provider.gateway.nil? | |||
| raise Puppet::Error, "#{provider.name} is missing the required parameter 'interface'." if provider.interface.nil? | |||
|
|
|||
| contents << "#{provider.network} #{provider.netmask} #{provider.gateway} #{provider.interface} #{provider.options}\n" | |||
| contents << "#{provider.network} #{provider.netmask} #{provider.gateway} #{provider.interface}" | |||
| contents << (provider.options == :absent ? "\n" : " #{provider.options}\n") | |||
There was a problem hiding this comment.
I'm not a big fan of encapsulated ternary. What do you think @igalic, do we want to keep it or reformat?
There was a problem hiding this comment.
contrast that with the code i replace in redhat.rb
|
maybe change the ternary. IMO it is not very readable in combination with the encapsulation and <<. Rest looks fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analogous to redhat, we check if options are absent, before appending
them to the file. This fixes #160