Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add EL8 Support and add missing EL flavours #316

Merged
merged 1 commit into from Dec 18, 2023
Merged

add EL8 Support and add missing EL flavours #316

merged 1 commit into from Dec 18, 2023

Conversation

SimonHoenscheid
Copy link
Sponsor Member

No description provided.

@rwaffen
Copy link
Sponsor Member

rwaffen commented Dec 7, 2023

there are no acceptance tests, does this really run on el8?

@silug
Copy link
Contributor

silug commented Dec 7, 2023

there are no acceptance tests, does this really run on el8?

I am using it on EL8. It does work.

On EL9, we really need NetworkManager support for things to work correctly.

@SimonHoenscheid
Copy link
Sponsor Member Author

there are no acceptance tests, does this really run on el8?

I am using it on EL8. It does work.

On EL9, we really need NetworkManager support for things to work correctly.

Is Systemd an option with EL9?

@SimonHoenscheid
Copy link
Sponsor Member Author

Should I add the other EL8 OS flavors?

@rwaffen
Copy link
Sponsor Member

rwaffen commented Dec 11, 2023 •
edited

in RHEL NetworkManager is the system default, i wouldn't recommend to go against it or work around it. It's not gonna go away, so we have to live with it.

Should I add the other EL8 OS flavors?

yes why not, it should behave all the same, otherwise it shouldn't call itself EL8 flavor... 🤔

@SimonHoenscheid SimonHoenscheid force-pushed the rhel8_support branch 2 times, most recently from 38ee054 to a999376 Compare December 18, 2023 15:12
@SimonHoenscheid SimonHoenscheid changed the title add RHEL8 and Centos8 Support add EL8 Support and add missing EL flavors Dec 18, 2023
@SimonHoenscheid SimonHoenscheid changed the title add EL8 Support and add missing EL flavors add EL8 Support and add missing EL flavours Dec 18, 2023
@SimonHoenscheid SimonHoenscheid merged commit 251d737 into voxpupuli:master Dec 18, 2023
4 checks passed
@SimonHoenscheid SimonHoenscheid deleted the rhel8_support branch December 18, 2023 17:57
@maureen-lawless
Copy link

Hi,

Will this fix be included in a tagged version soon?

Thanks,
Maureen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaffen rwaffen rwaffen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimonHoenscheid @rwaffen @silug @maureen-lawless