Allow customising the log prefix #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarrientos
force-pushed
the
custom_log_prefix
branch
from
da740a6
to
ed82738
Compare
|
Thank you. Not sure about the data extraction, personally I like defaults in the code and only e.g. moving per distro defaults out into data. But well, that's not really a strong opinion. |
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
0cf43fd Merge pull request voxpupuli#4 from cernops/dhcp6 37b2a3b Add class nftables::services::dhcpv6_client 883389d Merge pull request voxpupuli#5 from cernops/custom_log_prefix 4356626 Add rules for outgoing and incoming DHCPv6 client traffic ed82738 Allow customising the log prefix 317b8d0 Merge pull request voxpupuli#3 from cernops/ai5973 20b9636 Add support for named sets e4c3222 Use concat for table conf generation 18ec6f4 Fix rulenames which includes an index e5eb742 Allow to specify prometheus source addresses e73f2e9 Fix rule node exporter 8227cb1 Manage rule in dns cb50fd7 Add rule in node_exporter e105f14 Include table ip6 nat 248ef9d Add basic ip6 nat chains 579e27d Fix the regex for bridge names 2c00d76 Replace dashes with underlines git-subtree-dir: code git-subtree-split: 0cf43fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch partly implements #2, allowing the caller of the module to configure the prefix that's used to log when packets reach the end of the chains. Perhaps the default values of the parameters of the
nftablesclass should be moved to module-level Hiera data (data/common.yaml) to make it cleaner.