Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules for afs3_callback in and out rules for kerberos and openafs. #6

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

traylenator
Copy link
Collaborator

@traylenator traylenator commented Nov 16, 2020

Add the afs callback to the cache manager(7001) which is UDP and always
IPv4 since there OpenAFS does not support IPv6.

include nftables::rules::afs3_callback

For background OpenAFS servers connect to clients on the afs3_callback port and it is the server
initiating the connection. The clients have already connected to server on a completely different ports.

To configure an openafs client in totality

include nftables::services::openafs_client

which will allow both outbound connections clients need and the inbound cache callbacks.

https://wiki.openafs.org/devel/AFSServicePorts/

@traylenator
Copy link
Collaborator Author

Happy to add an nftables::rules::out::afs_client though to be honest it is not something we have real world experience of.

@traylenator
Copy link
Collaborator Author

@nbarrientos and I are happy to do some reviews of other MRs by the way.

@duritong
Copy link
Collaborator

Happy to add an nftables::rules::out::afs_client though to be honest it is not something we have real world experience of.

If you have at least an idea, what should be added, it would be nice to have it.

@traylenator traylenator changed the title Add rules for afs3_callback Add rules for afs3_callback in and out rules for kerberos and openafs. Nov 16, 2020
@traylenator
Copy link
Collaborator Author

@duritong I checked with one of the AFS admins who advised those ports. It may well differ for different cells but that's okay.

@traylenator traylenator marked this pull request as draft November 18, 2020 07:33
In particular the afs callback to the cache manager(7001) which is UDP and always
IPv4 since there OpenAFS does not support IPv6.

https://wiki.openafs.org/devel/AFSServicePorts/
@traylenator
Copy link
Collaborator Author

While writing the tests for nftables::rules I realised rule title can have a suffix on the end.
What was the idea here?

Should I use -1 and -2 for the kerberos udp and tcp rules.

On a related note I see there is a udp+tcp in one line but it is pretty unreadable.

inet filter input meta l4proto {tcp, udp} @th,16,16 { 88 }

can switch of course.

@traylenator traylenator marked this pull request as ready for review November 19, 2020 09:49
Copy link
Collaborator

@duritong duritong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link
Collaborator

@keachi keachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keachi keachi merged commit 7b14f6d into voxpupuli:master Nov 19, 2020
@traylenator traylenator added the enhancement New feature or request label Dec 10, 2020
@traylenator traylenator deleted the afs branch December 15, 2020 10:27
figless pushed a commit to figless/puppet-nftables that referenced this pull request Aug 25, 2021
a5f5fb1 Merge pull request voxpupuli#13 from traylenator/comment
21d0496 Merge pull request voxpupuli#14 from cernops/ct_away
7b14f6d Merge pull request voxpupuli#6 from traylenator/afs
ea96d5d Move ct rules from global to INPUT and OUTPUT
61f03b4 Switch $order$fragmenta/b to $order-$fragment-a/b
e53053c Add comments for all the nftable::rules entries
9785cd5 lint fix
215aee1 Add kerberos out and openafs_client out
f3f2870 Add rules for afs3_callback

git-subtree-dir: code
git-subtree-split: a5f5fb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants