Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #74 - ensure table are initialized before flushing them #75

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

duritong
Copy link
Collaborator

@duritong duritong commented Mar 1, 2021

fix #74

@nbarrientos nbarrientos added the bug Something isn't working label Mar 1, 2021
@nbarrientos
Copy link
Collaborator

Hehe, hacky fix. You're lucky that executing table inet foo {} when the table foo exists does not make nftables complain 😆

@duritong
Copy link
Collaborator Author

duritong commented Mar 2, 2021

I didn't really see a way to conditionally check for the existence of the table

@traylenator
Copy link
Collaborator

I noticed this myself after adding that original patch - but could not think of a good way.
The other option is just to completly remove the flush from start up since it is redundant. We would rely on the flush in reload only.

Lets go with this unless you think removing the flush completly is a better idea.

@traylenator traylenator merged commit 92e0fcb into voxpupuli:master Mar 2, 2021
@nbarrientos
Copy link
Collaborator

Perhaps a good time to create a release, there are two interesting fixes in master now.

@duritong
Copy link
Collaborator Author

duritong commented Mar 3, 2021

Question: do you know why the author was rewritten when merged? @traylenator

@traylenator
Copy link
Collaborator

This commt 92e0fcb is written by you ?

@duritong
Copy link
Collaborator Author

duritong commented Mar 3, 2021

I pushed & proposed to merge a4c3c76 but merged was 92e0fcb (also on master is this) - which is content-wise the same commit, except that the author got re-written, thus a different commit-sha.

So I was wondering why the author got re-written and whether you clicked anything special.

Background: When I now try to merge back upstream (this repo) I need either to merge or throw away my old commit, but this means I need to internally force push, which is also weird. Otherwise github started doing that which would be a really weird thing to start doing...

@traylenator
Copy link
Collaborator

whether you clicked anything special.

I clicked what ever was the default option when doing the merge assuming GH knows best.
I will take note next time what the options are and try and preserve.

figless pushed a commit to figless/puppet-nftables that referenced this pull request Aug 25, 2021
05c7f19 Release 1.2.0 (voxpupuli#76)
92e0fcb fix voxpupuli#74 - ensure table are initialized before flushing them (voxpupuli#75)
942569e Merge pull request voxpupuli#73 from Koumbit/global_chain_not_hardcoded
cf38fe4 create tests for presence of the "global" chain
1a4f336 start declaring the 'global' chain with module resources
ca0e975 Bump version to 1.1.2-rc0 (voxpupuli#72)

git-subtree-dir: code
git-subtree-split: 05c7f19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nftables service is broken after reboot
3 participants