-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #74 - ensure table are initialized before flushing them #75
Conversation
Hehe, hacky fix. You're lucky that executing |
I didn't really see a way to conditionally check for the existence of the table |
I noticed this myself after adding that original patch - but could not think of a good way. Lets go with this unless you think removing the flush completly is a better idea. |
Perhaps a good time to create a release, there are two interesting fixes in master now. |
Question: do you know why the author was rewritten when merged? @traylenator |
This commt 92e0fcb is written by you ? |
I pushed & proposed to merge a4c3c76 but merged was 92e0fcb (also on master is this) - which is content-wise the same commit, except that the author got re-written, thus a different commit-sha. So I was wondering why the author got re-written and whether you clicked anything special. Background: When I now try to merge back upstream (this repo) I need either to merge or throw away my old commit, but this means I need to internally force push, which is also weird. Otherwise github started doing that which would be a really weird thing to start doing... |
I clicked what ever was the default option when doing the merge assuming GH knows best. |
05c7f19 Release 1.2.0 (voxpupuli#76) 92e0fcb fix voxpupuli#74 - ensure table are initialized before flushing them (voxpupuli#75) 942569e Merge pull request voxpupuli#73 from Koumbit/global_chain_not_hardcoded cf38fe4 create tests for presence of the "global" chain 1a4f336 start declaring the 'global' chain with module resources ca0e975 Bump version to 1.1.2-rc0 (voxpupuli#72) git-subtree-dir: code git-subtree-split: 05c7f19
fix #74