start declaring the 'global' chain with module resources #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the 'global' chain is a vestigial piece of early development on this module, but it can be useful for creating fast short-circuits like blocking traffic that match a certain set of IPs. in the current state we can't inject rules inside the 'global' chain since it's unknown to puppet. so let's remove the hard-coded definition and use a puppet resource to declare it.
|
Sound good. Could perhaps some extra test coverage be added to |
|
yeah, let's add a spec and merge. |
|
@nbarrientos ah yes good point, I forgot to add tests. I've just sent the added tests, let's see how CI likes them (at least locally they were failing on the master branch and successful on top of this branch) |
duritong
approved these changes
Feb 14, 2021
|
thank you! |
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
05c7f19 Release 1.2.0 (voxpupuli#76) 92e0fcb fix voxpupuli#74 - ensure table are initialized before flushing them (voxpupuli#75) 942569e Merge pull request voxpupuli#73 from Koumbit/global_chain_not_hardcoded cf38fe4 create tests for presence of the "global" chain 1a4f336 start declaring the 'global' chain with module resources ca0e975 Bump version to 1.1.2-rc0 (voxpupuli#72) git-subtree-dir: code git-subtree-split: 05c7f19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 'global' chain is a vestigial piece of early development on this
module, but it can be useful for creating fast short-circuits like
blocking traffic that match a certain set of IPs.
in the current state we can't inject rules inside the 'global' chain
since it's unknown to puppet. so let's remove the hard-coded definition
and use a puppet resource to declare it.