Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx::service::service_enable does not exist #1208

Closed
fnoop opened this issue Apr 22, 2018 · 3 comments · Fixed by #1217
Closed

nginx::service::service_enable does not exist #1208

fnoop opened this issue Apr 22, 2018 · 3 comments · Fixed by #1217
Labels
beginner-friendly enhancement New feature or request

Comments

@fnoop
Copy link
Contributor

fnoop commented Apr 22, 2018

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 5.5.0
  • Ruby: 2.3.3p222
  • Distribution: Raspbian (Debian stretch)
  • Module version: 0.9.1-rc0

How to reproduce (e.g Puppet code you use)

    class { 'nginx':
        service_manage  => true,
        service_ensure  => $service_ensure,
        service_enable  => $service_enable,
    }

What are you seeing

Error: Evaluation Error: Error while evaluating a Resource Statement, Class[Nginx]: has no parameter named 'service_enable' (file: /srv/maverick/software/maverick/manifests/maverick-modules/maverick_web/manifests/nginx.pp, line: 55, column: 5) on node maverick-raspberrylite.home

What behaviour did you expect instead

To control the service at boot

Output log

Any additional information you'd like to impart

Adding the service_enable parameter to index.pp and service.pp makes it behave as expected

@fnoop
Copy link
Contributor Author

fnoop commented Apr 22, 2018

Ah sorry I see it's generated from service_ensure. Most other modules have it as a separately controlled parameter, for consistency and user control would be better as separate, possibly.

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Apr 22, 2018
@ekohl
Copy link
Member

ekohl commented Apr 24, 2018

@fnoop this should be a small addition and you already know where to make it. Could you come up with a PR to add this?

@fnoop
Copy link
Contributor Author

fnoop commented May 3, 2018

PR raised

fnoop added a commit to fnoop/puppet-nginx that referenced this issue May 17, 2018
fnoop added a commit to fnoop/puppet-nginx that referenced this issue May 17, 2018
bastelfreak added a commit that referenced this issue Jul 7, 2018
Add service_enable and simplify service_ensure, #1208
ceonizm pushed a commit to ceonizm/puppet-nginx that referenced this issue Jan 23, 2019
ceonizm pushed a commit to ceonizm/puppet-nginx that referenced this issue Jan 23, 2019
ceonizm pushed a commit to ceonizm/puppet-nginx that referenced this issue Jan 23, 2019
ceonizm pushed a commit to ceonizm/puppet-nginx that referenced this issue Jan 23, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
Add service_enable and simplify service_ensure, voxpupuli#1208
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Add service_enable and simplify service_ensure, voxpupuli#1208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly enhancement New feature or request
Projects
None yet
3 participants