Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRPEv3 Support for FreeBSD - Add param listen_queue_size #64

Merged
merged 13 commits into from
Mar 10, 2023
Merged

NRPEv3 Support for FreeBSD - Add param listen_queue_size #64

merged 13 commits into from
Mar 10, 2023

Conversation

Toutzn
Copy link

@Toutzn Toutzn commented Apr 14, 2022

Pull Request (PR) description

Packagestyle not supported under FreeBSD yet.
Added the right package style with FreeBSD NRPEv3 support.
Added new variable to setup listen_queue_size for huge set of monitoring commands
Include description of variable into the readme.

This Pull Request (PR) fixes the following issues

Torsten Wilms added 2 commits April 14, 2022 14:57
- add queue_listen_size support for NRPE because if you have a huge s…
aa76eea 
…et of nrpe checks, a default limit of 5 is not enough.

- add FreeBSD support | FreeBSD use nrpe v3 and it could be installed via pkg without net-mgmt
add doc into readme
bfe734e
@tuxmea
Copy link
Member

tuxmea commented Mar 7, 2023

@alexjfisher @bastelfreak Patch provided by a FreeBSD user. Can you please review?

@bastelfreak
Copy link
Member

@Toutzn thanks for the OR and sorry for the slow response. Do you know on whichFreeBSD versions this works? Could you add then to the metadata.json?

@Toutzn
Copy link
Author

Toutzn commented Mar 7, 2023

I see test never written for FreeBSD. needs to be done...

@Toutzn
Copy link
Author

Toutzn commented Mar 7, 2023

CentOS tests run into connection refused on 127.0.0.1.
How can I add FreeBSD VMs to test code on that? @bastelfreak

@bastelfreak
Copy link
Member

@Toutzn please rebase against our latest master branch. I merged #63 which fixed the CentOS 7 errors. For FreeBSD we currently don't support acceptance tests, so dont worry about that.

@Toutzn Toutzn closed this Mar 9, 2023
Torsten Wilms and others added 2 commits March 9, 2023 20:29
@Toutzn
- add queue_listen_size support for NRPE because if you have a huge s…
4e454e3 
…et of nrpe checks, a default limit of 5 is not enough.

- add FreeBSD support | FreeBSD use nrpe v3 and it could be installed via pkg without net-mgmt
@Toutzn
revert
2d2b5ba
@Toutzn Toutzn reopened this Mar 9, 2023
Toutzn
Toutzn commented Mar 9, 2023
View reviewed changes
Copy link
Author

@Toutzn Toutzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be ok

@bastelfreak
Copy link
Member

the REFERENCE.md is outdated, that's blocking the CI. Can you please update it? bundle exec rake strings:generate:reference

@Toutzn
Copy link
Author

Toutzn commented Mar 9, 2023

Hi, I am not sure if I do something wrong, but now the static validations goes broken because of Missing @param tag for parameter

bastelfreak
bastelfreak reviewed Mar 9, 2023
View reviewed changes
REFERENCE.md Outdated
@@ -385,6 +385,7 @@ Whether to log details of client SSL certificates.

Default value: `false`

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a broken rebase

bastelfreak
bastelfreak reviewed Mar 9, 2023
View reviewed changes
REFERENCE.md Outdated
@@ -394,6 +395,17 @@ Whether to manage the directory where the PID file should exist.
Default value: `false`

##### <a name="-nrpe--config"></a>`config`
=======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a broken rebase

bastelfreak
bastelfreak reviewed Mar 9, 2023
View reviewed changes
manifests/init.pp
@@ -135,6 +135,7 @@
Stdlib::Filemode $command_file_default_mode = '0644',
Array[String[1]] $supplementary_groups = [],
Boolean $manage_pid_dir = false,
Integer[0] $listen_queue_size = $nrpe::params::listen_queue_size,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please document the parameter in the header of the file

@Toutzn
Copy link
Author

Toutzn commented Mar 9, 2023

I did all my documentation. Someone needs to fix issues like

[warn]: Missing @param tag for parameter 'ssl_log_startup_params' near functions/ssl_logging.pp:17. [11](https://github.com/voxpupuli/puppet-nrpe/actions/runs/4378662276/jobs/7663681834#step:5:12) [warn]: Missing @param tag for parameter 'ssl_log_remote_ip' near functions/ssl_logging.pp:17. [12](https://github.com/voxpupuli/puppet-nrpe/actions/runs/4378662276/jobs/7663681834#step:5:13) [warn]: Missing @param tag for parameter 'ssl_log_protocol_version' near functions/ssl_logging.pp:17. [13](https://github.com/voxpupuli/puppet-nrpe/actions/runs/4378662276/jobs/7663681834#step:5:14) [warn]: Missing @param tag for parameter 'ssl_log_cipher' near functions/ssl_logging.pp:17. [14](https://github.com/voxpupuli/puppet-nrpe/actions/runs/4378662276/jobs/7663681834#step:5:15) [warn]: Missing @param tag for parameter 'ssl_log_client_cert' near functions/ssl_logging.pp:17. [15](https://github.com/voxpupuli/puppet-nrpe/actions/runs/4378662276/jobs/7663681834#step:5:16) [warn]: Missing @param tag for parameter 'ssl_log_client_cert_details' near functions/ssl_logging.pp:17. [16](https://github.com/voxpupuli/puppet-nrpe/actions/runs/4378662276/jobs/7663681834#step:5:17) [warn]: Missing @return tag near functions/ssl_logging.pp:17. [17](https://github.com/voxpupuli/puppet-nrpe/actions/runs/4378662276/jobs/7663681834#step:5:18) [warn]: Missing documentation for Puppet type alias 'Nrpe::Sslversion' at types/sslversion.pp:8. [18](https://github.com/voxpupuli/puppet-nrpe/actions/runs/4378662276/jobs/7663681834#step:5:19) [warn]: Missing documentation for Puppet type alias 'Nrpe::Syslogfacility' at types/syslogfacility.pp:1.
right?

@bastelfreak
Copy link
Member

those warnings can be ignored. It looks like the REFERENCE.md got generated with an old version of puppet-strings (version2 vs 3). If you use bundler to manage your local gems I suggest to run something like bundle update. Afterwards regenerate the REFERENCE.md.

@Toutzn
Copy link
Author

Toutzn commented Mar 10, 2023

hmm. I am using rube 3.0.0 and puppet-strings (default: 3.0.1, 2.9.0).

@bastelfreak bastelfreak added the enhancement New feature or request label Mar 10, 2023
@Toutzn
Copy link
Author

Toutzn commented Mar 10, 2023

Jey. Got it now @bastelfreak :D

@tuxmea tuxmea merged commit c51a5d5 into voxpupuli:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@tuxmea tuxmea tuxmea approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Toutzn @tuxmea @bastelfreak