Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readd dependencies to class to generate configs #119

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

trefzer
Copy link
Contributor

@trefzer trefzer commented Dec 18, 2020

That was a bit fast to remove...

this reverts ae510aa
from pull request #116 (remove dependencies since we have autorequire)
and adds the dependencies between openssl config file and cert generations.

the autorequire mentioned in the the original commit, meant the
newly available autorequire in the defined types. But that one is
an autorequire for the directory where we put the file to generate, not
the configuration file !

That was a bit fast to remove...

this reverts ae510aa
from pull request voxpupuli#116 (remove dependencies since we have autorequire)
and adds the dependencies between openssl config file and cert generations.

the autorequire mentioned in the the original commit, meant the
newly available autorequire in the defined types. But that one is
an autorequire for the directory where we put the file to generate, not
the configuration file !
@puppet-community-rangefinder
Copy link

openssl::configs is a class

that may have no external impact to Forge modules.

This module is declared in 2 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@raphink raphink merged commit 67fcecb into voxpupuli:master Jan 12, 2021
@trefzer trefzer deleted the fix_config_dependency branch January 18, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants