add class to generate configs #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl::configs is a classthat may have no external impact to Forge modules. This module is declared in 2 of 575 indexed public
|
trefzer
force-pushed
the
fix_add_configs_class
branch
from
f64727f
to
82e85aa
Compare
raphink
reviewed
Dec 16, 2020
manifests/configs.pp
Outdated
| # dpendencies: ensure config file is generated before potential usage | ||
| File<| tag=='openssl-configs' |> -> Ssl_pkey<| |> | ||
| File<| tag=='openssl-configs' |> -> X509_cert<| |> | ||
| File<| tag=='openssl-configs' |> -> X509_request<| |> |
There was a problem hiding this comment.
I believe #117 makes this moot, as each type now autorequires its config file.
raphink
reviewed
Dec 16, 2020
raphink
reviewed
Dec 16, 2020
raphink
reviewed
Dec 16, 2020
The new class openssl::configs create openssl.conf files. The generation bases on a new .epp template since epp can use parameters which was easier to integrate. closes: voxpupuli#41
trefzer
force-pushed
the
fix_add_configs_class
branch
from
82e85aa
to
9cc6b9b
Compare
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
trefzer
added a commit
to cirrax/puppet-openssl
that referenced
this pull request
Dec 18, 2020
That was a bit fast to remove... this reverts ae510aa from pull request voxpupuli#116 (remove dependencies since we have autorequire) and adds the dependencies between openssl config file and cert generations. the autorequire mentioned in the the original commit, meant the newly available autorequire in the defined types. But that one is an autorequire for the directory where we put the file to generate, not the configuration file !
raphink
pushed a commit
that referenced
this pull request
Jan 12, 2021
That was a bit fast to remove... this reverts ae510aa from pull request #116 (remove dependencies since we have autorequire) and adds the dependencies between openssl config file and cert generations. the autorequire mentioned in the the original commit, meant the newly available autorequire in the defined types. But that one is an autorequire for the directory where we put the file to generate, not the configuration file !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new class openssl::configs create openssl.conf files.
The generation bases on a new .epp template since epp can
use parameters which was easier to integrate.
closes: #41