-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow DER certificates to be converted to PEM format #122
Conversation
merge from uptream
openssl::export::pem_cert is a typethat may have no external impact to Forge modules. openssl::export::pem_key is a typethat may have no external impact to Forge modules. This module is declared in 2 of 576 indexed public
|
Thanks for that. I've added a few comments. |
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad. Linting issues ;-)
Augments the openssl::export::pem_cert code to test on DER certificates. Change der_cert and pfx_cert to optional to allow the removal of cert to succeed. There is a unit test to confirm all functionality