Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DER certificates to be converted to PEM format #122

Merged
merged 18 commits into from
May 4, 2021

Conversation

n3mawashi
Copy link
Contributor

@n3mawashi n3mawashi commented Apr 19, 2021

Augments the openssl::export::pem_cert code to test on DER certificates. Change der_cert and pfx_cert to optional to allow the removal of cert to succeed. There is a unit test to confirm all functionality

@puppet-community-rangefinder
Copy link

openssl::export::pem_cert is a type

that may have no external impact to Forge modules.

openssl::export::pem_key is a type

that may have no external impact to Forge modules.

This module is declared in 2 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

manifests/export/pem_cert.pp Outdated Show resolved Hide resolved
manifests/export/pem_cert.pp Outdated Show resolved Hide resolved
manifests/export/pem_cert.pp Outdated Show resolved Hide resolved
manifests/export/pem_cert.pp Outdated Show resolved Hide resolved
spec/defines/openssl_export_pem_cert_spec.rb Outdated Show resolved Hide resolved
spec/defines/openssl_export_pem_cert_spec.rb Outdated Show resolved Hide resolved
spec/defines/openssl_export_pem_cert_spec.rb Outdated Show resolved Hide resolved
spec/defines/openssl_export_pem_cert_spec.rb Outdated Show resolved Hide resolved
spec/defines/openssl_export_pem_cert_spec.rb Outdated Show resolved Hide resolved
@raphink
Copy link
Member

raphink commented Apr 30, 2021

Thanks for that. I've added a few comments.

Peter Tiggerdine and others added 9 commits May 3, 2021 10:26
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Copy link
Member

@raphink raphink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. Linting issues ;-)

spec/defines/openssl_export_pem_cert_spec.rb Outdated Show resolved Hide resolved
spec/defines/openssl_export_pem_cert_spec.rb Outdated Show resolved Hide resolved
@raphink raphink added the enhancement New feature or request label May 4, 2021
@raphink raphink merged commit f3965aa into voxpupuli:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants