dhparam: add #53
Merged
dhparam: add #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephholsten
force-pushed
the
dhparam
branch
5 times, most recently
from
ba7e339
to
e0d99ba
Compare
|
ok, this has been updated with complete error-handling and green-path tests, as well as documentation. The failing test is due to different validation error output on puppet 4 for |
|
Thank you. I just fixed the error on |
|
@raphink updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should be using a stronger-than-default dhparam for modern TLS configuration to mitigate https://weakdh.org/
This makes it easy to do so.