allow pipe param for pecl extensions #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
Jan 19, 2017
| @@ -66,6 +70,7 @@ | |||
| $settings = {}, | |||
| $settings_prefix = false, | |||
| $sapi = 'ALL', | |||
| $pipe = undef, | |||
There was a problem hiding this comment.
Does $pipe then not also have to be passed as an argument to ensure_packages?
There was a problem hiding this comment.
Thanks! I ran the wrong test on my side and missed this. PR updated
alexjfisher
reviewed
Jan 19, 2017
| @@ -52,6 +52,10 @@ | |||
| # String parameter, whether to specify ALL sapi or a specific sapi. | |||
| # Defaults to ALL. | |||
| # | |||
| # [*pipe*] | |||
| # String parameter that may be used by the *provider* to input answers during | |||
There was a problem hiding this comment.
Maybe mention it's for the 'pecl' provider only here?
There was a problem hiding this comment.
Hoping this will be updated correctly in the future, sure :)
rnelson0
approved these changes
Jan 19, 2017
There was a problem hiding this comment.
The current rubocop error is due to a modulesync issue and should not hold up the merge, once @alexjfisher's concerns have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf https://github.com/voxpupuli/puppet-php/blob/master/lib/puppet/provider/package/pecl.rb#L83