fix pecl/pear providers query method #298
Conversation
|
@cbaoxa would you mind adding a spec test for this so we can maybe learn from our horrible mistakes of the past? |
ghost
changed the title
|
@igalic sure, working on it, plus maybe merging all the features in the pear provider, as it can handle both pear and pecl extensions |
| ======================================== | ||
| (no packages installed) | ||
|
|
||
| [1mInstalled packages, channel pear.php.net:[m |
There was a problem hiding this comment.
is it not possible to get this lists without those ansi characters?
There was a problem hiding this comment.
Not directly with pear arguments, but it is with ENV['TERM']='dumb'
lib/puppet/provider/package/pear.rb
Outdated
| else | ||
| commands pearcmd: 'pear' | ||
| end | ||
| commands pearcmd: 'pear' |
There was a problem hiding this comment.
i'd just call this pear… you can maybe add a wrapper with default options that you call pearcmd (or vice versa?)
|
@bastelfreak is there any way to fix the 1.9 failures, or can we just gracefully ignore them for now? |
query method could return info about another package example: pry> @resource => Package[pecl-mongo] pry> self.class.pecllist(justme: peclname) => {:name=>"pecl-apcu", :ensure=>"4.0.7", :provider=>:peclcmd} this wrongly results in pecl-mongo not being installed although it is needed fixes #255 as well by returning the correct version for installed packages add pecl_spec and pear_spec too pecl is now a simple wrapper to pear, which can handle both kind of packages
|
PR updated wrt @igalic comments. |
ghost
changed the title
|
thank you so much @cbaoxa \o/ |
ghost
deleted the
could return info about another package
example:
this wrongly results in pecl-mongo not being installed when needed
fixes #255 as well by returning the correct version for installed
packages