Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PHP 5.5 in Ubuntu #308

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

thaiphv
Copy link
Contributor

@thaiphv thaiphv commented Feb 13, 2017

PHP 5.5 on Ubuntu is no longer available for download from the "ondrej/php" PPA. I think we should fail the execution when people want to install it.

@igalic
Copy link
Contributor

igalic commented Feb 13, 2017

@thaiphv thank you very much for this pr
you may want to consider adding the commit email to your github profile (for internet points)
or else, amending this commit's author

@thaiphv
Copy link
Contributor Author

thaiphv commented Feb 13, 2017

@igalic thanks for the suggestions. I've just pushed my email change.

Copy link
Member

@sacres sacres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; merging

@sacres sacres merged commit 34fb575 into voxpupuli:master Feb 16, 2017
@sacres
Copy link
Member

sacres commented Feb 16, 2017

Apologies for not saying so when merging/reviewing: Thanks @thaiphv !

@thaiphv
Copy link
Contributor Author

thaiphv commented Feb 16, 2017

@sacres no worries. Thanks for accepting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants