Fix wrongly named parameters for apt::source/key

[bitcrush]

This PR fixes a naming issue in php::repo::debian. The parameters given to the apt::key and apt::source defined types are not valid for the puppetlabs/apt module >= 4.4.0, which this module depends on.

[c33s]

can you please also put the whole php7.1 part in an if and add a flag to it?

class php::repo::debian(
  $location     = 'http://packages.dotdeb.org',
  $release      = 'wheezy-php56',
  $repos        = 'all',
  $include_src  = false,
  $key          = {
    'id'     => '6572BBEF1B5FF28B28B706837E3F070089DF5277',
    'source' => 'http://www.dotdeb.org/dotdeb.gpg',
  },
  $dotdeb       = true,
  $sury         = true,
) {

and

if ($sury and $php::globals::php_version == '7.1') {
...

as i wrote #293 (comment) if you use the manage repo and provide the sury repo by hiera the new php7.1 section in this module part break it.

[bitcrush]

I implemented the requested flag. However the class lags functionality/configurabiltity. This is a proposal that should solve the issues mentioned in #293. In addition it adds support for PHP 7.2 on Jessie and Stretch. Please have a look and let me know if I should create another PR for it.

[c33s]

if i would have merge permissions i would merge/approve your PR but we have to wait for someone with merge permissions here.

[bastelfreak]

Hi @bitcrush and @c33s, thanks for the work here!

[bastelfreak]

preferred way would be to use the new facts hash instead of a topscope variable. If you want you can change this in another PR, or we just stick with it.