-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrongly named parameters for apt::source/key #420
Fix wrongly named parameters for apt::source/key #420
Conversation
can you please also put the whole php7.1 part in an if and add a flag to it?
and
as i wrote #293 (comment) if you use the manage repo and provide the sury repo by hiera the new php7.1 section in this module part break it. |
if i would have merge permissions i would merge/approve your PR but we have to wait for someone with merge permissions here. |
include_src => false, | ||
require => [ | ||
location => 'https://packages.sury.org/php/', | ||
release => $::lsbdistcodename, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preferred way would be to use the new facts hash instead of a topscope variable. If you want you can change this in another PR, or we just stick with it.
This PR fixes a naming issue in php::repo::debian. The parameters given to the apt::key and apt::source defined types are not valid for the puppetlabs/apt module >= 4.4.0, which this module depends on.