modulesync 2.12.0 #513
modulesync 2.12.0 #513
Conversation
bastelfreak
added
backwards-incompatible
modulesync
and removed
backwards-incompatible
labels
|
is it really a good step to remove puppet4 support? what are the benefits of dropping the support for puppet4? debians current lts is supported until June 2022 (stretch) which ships puppet 4.8. you are defacto killing the native puppet support in currents debian stable. https://en.wikipedia.org/wiki/Debian_version_history#Debian_9_(Stretch) |
|
Hi @c33s. This is the result of a pretty long discussion which happend in voxpupuli/voxpupuli.github.io#157. |
|
These tests must be converted from mocha to rspec-mocks. |
|
Dear @bastelfreak, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
dhoppe
changed the title
|
Dear @bastelfreak, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
dhoppe
changed the title
dhoppe
changed the title
bastelfreak
changed the title
|
LGTM |
| @@ -19,7 +19,4 @@ | |||
| - set: debian9-64 | |||
| options: | |||
| script: 'bundle exec rspec spec/acceptance/php_spec.rb' | |||
| - set: debian8-64 | |||
There was a problem hiding this comment.
@bastelfreak We should keep this, since Debian 8 is not EOL until 2020-06-30.
dhoppe
force-pushed
the
modulesync
branch
3 times, most recently
from
842dee2
to
3845a84
Compare
spec/acceptance/php_spec.rb
Outdated
| @@ -10,12 +10,10 @@ | |||
| end | |||
|
|
|||
| case default[:platform] | |||
| when %r{ubuntu-18.04} | |||
There was a problem hiding this comment.
I'm generally a fan of smaller diffs and keeping it newest to oldest is OK IMHO. It's still sorted and consistent.
dhoppe
force-pushed
the
modulesync
branch
2 times, most recently
from
dfef06c
to
060d46f
Compare
| expect(described_class.instances).to eq [] | ||
| end | ||
| end | ||
|
|
||
| describe '#install' do | ||
| it 'installs a package' do | ||
| described_class.expects(:pear). | ||
| allow(described_class).to receive(:pear). | ||
| with('-D', 'auto_discover=1', 'upgrade', '--alldeps', 'dummy') | ||
| provider.install |
There was a problem hiding this comment.
To really replace this and keep the test, you should add a have_received assertion. This is repeated so I won't comment it everywhere.
| provider.install | |
| provider.install | |
| expect(described_class).to have_receive(:pear) |
There was a problem hiding this comment.
I already tried this, but it did not work as expected:
|
as this finally works, I'm going to merge it for now. We can still improve it later on. |
|
yeah no puppet4 drop 👍 😄 💯 🥇 |
modulesync 2.7.0