Do not manage mysql.ini when using Ubuntu repo (and fix CI) #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 7.0+ packaged with Ubuntu does not ship with mysql.so, and enabling the module should not setup a mysql.ini file referring to it.
Ubuntu 14.04 LTS has reached EOL on the 17th of April 2019 Ondřej Surý's repository of PHP packages for Ubuntu does not ship packages for Ubuntu 14.04 anymore. Remove all acceptance tests running on this unsupported version of Ubuntu and add missing test against Ubuntu 18.04 TLS.
smortex
changed the title
Dan33l
approved these changes
May 28, 2019
bastelfreak
added a commit
to bastelfreak/puppet-php
that referenced
this pull request
May 29, 2019
Ubuntu 14.04 is End of Life. We already removed parts in voxpupuli#519
Merged
motivator
pushed a commit
to bigcommerce/puppet-php
that referenced
this pull request
Oct 5, 2020
Ubuntu 14.04 is End of Life. We already removed parts in voxpupuli#519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
PHP 7.0+ packaged with Ubuntu does not ship with mysql.so, and enabling the module should not setup a mysql.ini file referring to it.
This is an adaptation of #330 which has been stale for some times…
This Pull Request (PR) fixes the following issues
Fixes #330