-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow hiera driven transport/virtual/hash/conffile #296
Conversation
cringdahl
commented
Jul 9, 2021
- add more create_resources in init.pp
- remove overt init->hash requirement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will need spec tests added. Here is an example at https://github.com/voxpupuli/puppet-postfix/blob/master/spec/classes/postfix_spec.rb#L468
A simpler set of tests would be for each of these additions, you give a param with data and check that postfix::XYZ { 'data': }
resource is present.
Here's an example of similar code at https://github.com/sensu/sensu-puppet/blob/master/manifests/resources.pp which is iterating over the hash instead of create_resources()
and is the new way to do things. You dont need to adopt that here as there is existing code that you are matching. Example spec tests at https://github.com/sensu/sensu-puppet/blob/master/spec/classes/resources_spec.rb
@cringdahl Thanks for the contribution! |
Thanks for the pointers and the New Way example link. Much appreciated. |
@cringdahl Awesome work! Could you please rebase and squash your commits into one and I'll merge this. |
a36d575
to
06a380c
Compare
hey, @ghoneycutt , just a quick ping to get this merged in, thanks |