Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add envvars support to daemon #151

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

costela
Copy link

@costela costela commented Jan 25, 2018

This adds support for providing environment variables to prometheus::daemon instances. This is needed for some exporters, like rabbitmq's

Fixes #150

@costela costela force-pushed the add_envvars_to_daemon branch 2 times, most recently from 21f7f7b to 03f7009 Compare January 25, 2018 09:57
$service_ensure = 'running',
$service_enable = true,
$manage_service = true,
Hash[String, Scalar] $env_vars = {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datatypes \o/

@bastelfreak bastelfreak added the enhancement New feature or request label Jan 25, 2018
@bastelfreak
Copy link
Member

Thanks for the PR @costela!

@bastelfreak bastelfreak merged commit 3358eb2 into voxpupuli:master Jan 25, 2018
@costela costela deleted the add_envvars_to_daemon branch January 25, 2018 13:16
This was referenced Jan 28, 2018
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants