Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rabbitmq exporter #153

Merged
merged 3 commits into from Feb 2, 2018
Merged

Conversation

costela
Copy link

@costela costela commented Jan 31, 2018

This adds a rabbitmq_exporter class.
It also corrects a couple of remaining issues from #151, regarding proper quoting and exporting of environment variables under certain init_style conditions.

Fixes #149

upstart's use of exec means we have to export the variables loaded from the defaults file. Since we're using the same default file for multiple init styles, it seems cleaner to make this exporting explicit on upstart's side.

refs voxpupuli#150
@tuxmea
Copy link
Member

tuxmea commented Feb 1, 2018

Minor issue with documentation using old class name.

@costela
Copy link
Author

costela commented Feb 1, 2018

@tuxmea oops, good catch! Fixed that and missing docs for extra_env_vars parameter.

@tuxmea
Copy link
Member

tuxmea commented Feb 2, 2018

looks good to me.

@bastelfreak bastelfreak added the enhancement New feature or request label Feb 2, 2018
@bastelfreak
Copy link
Member

thanks for the PR @costela !

@bastelfreak bastelfreak merged commit 2b40332 into voxpupuli:master Feb 2, 2018
@costela costela deleted the rabbitmq_exporter branch February 2, 2018 10:02
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants