fix bug in types that int[0,1] were boolean #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
there is some discrepancy between values in types\resource and proxysql. By default some of them are boolean in types, had [0,1] regexp checks in resouce and are defined as INT CHECK (negate_match_pattern IN (0,1)) in proxysql.
Because of it is impossible to set them in manifest
For example, setting
"transaction_persistent": 0
for user will lead to:Evaluation Error: Error while evaluating a Method call, Class[Db::Proxysql]: parameter 'mysql_users' index 0 entry 'app' entry 'transaction_persistent' expects a Boolean value, got Integer
and setting
"transaction_persistent": false
for user will lead to:Failed to apply catalog: Parameter transaction_persistent failed on Proxy_mysql_user[app]: Invalid value false. Valid values match /[01]/.