-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install from PyPI package and keep up to date by default #354
Install from PyPI package and keep up to date by default #354
Conversation
I was inspired by the original report of #353 in voxpupuli/puppetboard#680, as I was not even able to learn what Puppetboard version was he using based on his code... |
f8b7b9f
to
8cd78f8
Compare
Can you please check this out, @bastelfreak @smortex @kenyon? The failing tests seem to be breaking on puppetdb, not puppetboard. PS I know that this would need a major release as it's a backward-incompatible change but I think it's worth it. |
bdcc767
to
2212761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea to me.
I just merged #352 which should also fix your issues. Can you rebase on top of it? From your working directory:
|
8f8d353
to
48c2a6a
Compare
Done, @smortex, but I have to clean up some unnecessary changes, please hold on with merging. |
Puppetboard developers follow semver, use pre-releses and put a lot of effort into making the PyPI (and Docker) the best way to install the app. vcsrepo installation method should be used only by the contributors (as: developers and testers of non-releases).
48c2a6a
to
00e6ce9
Compare
for a given installation method
Ok, done. I have also added some extra validation as over the past few days I have learned the hard way that it's very easy to not get the version you expect if you mess up the params, if you don't have such validation. 🙄 |
What do you think, @smortex, is it merge’able now? |
Thanks @kenyon! ..but I actually don’t have the permissions to merge it on my own. 😞 |
THANK YOU!!! |
Pull Request (PR) description
Puppetboard developers follow semver, use pre-releses and put a lot of effort into making the PyPI (and Docker) the best way to install the app.
vcsrepo installation method should be used only by the contributors (as: developers and testers of non-releases).
This Pull Request (PR) fixes the following issues