Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default for command_prefix is broken #15

Closed
alexjfisher opened this issue Feb 18, 2019 · 2 comments
Closed

Default for command_prefix is broken #15

alexjfisher opened this issue Feb 18, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@alexjfisher
Copy link
Member

puppet-puppetwebhook/data/common.yaml

Line 19 in c3719a5

command_prefix: '0022'

should be umask 0022;?
@alexjfisher
Copy link
Member Author

Probably should just be made Optional with no default?

@dhollinger
Copy link
Member

Either is probably fine

@dhollinger dhollinger added the bug Something isn't working label Feb 23, 2019
alexjfisher added a commit to alexjfisher/puppet-puppetwebhook that referenced this issue Mar 1, 2019
@alexjfisher
Remove broken default command_prefix
20dd4b2 
Fixes voxpupuli#15
@alexjfisher alexjfisher mentioned this issue Mar 1, 2019
Merged
alexjfisher added a commit to alexjfisher/puppet-puppetwebhook that referenced this issue Mar 1, 2019
@alexjfisher
Remove broken default command_prefix
25c39fe 
Fixes voxpupuli#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexjfisher @dhollinger