Skip to content

Commit

Permalink
Merge pull request #315 from mbmilligan/mbmilligan-fix-tests
Browse files Browse the repository at this point in the history
Tweaks to get travis ci tests working again
  • Loading branch information
ghoneycutt committed Jul 15, 2016
2 parents 333de56 + 315efa0 commit c6ac464
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
4 changes: 4 additions & 0 deletions Gemfile
Expand Up @@ -17,6 +17,10 @@ else
gem 'rake', :require => false
end

if RUBY_VERSION >= '1.8.7' and RUBY_VERSION < '2.0'
gem 'json', '~> 1.0'
end

if facterversion = ENV['FACTER_GEM_VERSION']
gem 'facter', facterversion, :require => false
else
Expand Down
3 changes: 2 additions & 1 deletion Rakefile
Expand Up @@ -12,6 +12,7 @@ end
PuppetLint.configuration.fail_on_warnings
PuppetLint.configuration.send('relative')
PuppetLint.configuration.send('disable_80chars')
PuppetLint.configuration.send('disable_140chars')
PuppetLint.configuration.send('disable_class_inherits_from_params_class')
PuppetLint.configuration.send('disable_class_parameter_defaults')
PuppetLint.configuration.send('disable_documentation')
Expand All @@ -36,4 +37,4 @@ task :test => [
:syntax,
:lint,
:spec,
]
]
4 changes: 2 additions & 2 deletions manifests/pip.pp
Expand Up @@ -85,15 +85,15 @@

$python_provider = getparam(Class['python'], 'provider')
$python_version = getparam(Class['python'], 'version')

# Get SCL exec prefix
# NB: this will not work if you are running puppet from scl enabled shell
$exec_prefix = $python_provider ? {
'scl' => "scl enable ${python_version} -- ",
'rhscl' => "scl enable ${python_version} -- ",
default => '',
}

# Parameter validation
if ! $virtualenv {
fail('python::pip: virtualenv parameter must not be empty')
Expand Down

0 comments on commit c6ac464

Please sign in to comment.