Fix undefined method error in facts #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partly fixes voxpupuli#527. Signed-off-by: Wiebe Verweij <wiebe.verweij@moxio.com>
Partially fixes voxpupuli#527 Signed-off-by: Wiebe Verweij <wiebe.verweij@moxio.com>
wiebe
force-pushed
the
fix_undefined_method_error_in_facts
branch
from
8ad245a
to
99ab8cc
Compare
|
thanks for the PR! |
bastelfreak
added
enhancement
bastelfreak
added a commit
to bastelfreak/puppet-python
that referenced
this pull request
Sep 13, 2020
voxpupuli#555 introduced new tests. In the same time we adjusted our test setup on the master branch and voxpupuli#555 wasn't rebased before merging. This PR fixes the tests.
Merged
russellshackleford
pushed a commit
to russellshackleford/puppet-python
that referenced
this pull request
Sep 28, 2020
voxpupuli#555 introduced new tests. In the same time we adjusted our test setup on the master branch and voxpupuli#555 wasn't rebased before merging. This PR fixes the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Prevents fact errors when pip/virtualenv installation is broken and adds version fact for pip2 and pip3.
This Pull Request (PR) fixes the following issues
Fixes #527