Duplicate certpath key #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acidprime Though the tests fail, looks good to merge to my eyes. (hoping to address test issues at puppetconf) |
|
Thanks @rnelson0. Tests are failing for reasons unrelated to these changes (json_pure requires ruby >=2.0). |
|
I'm working on a fix for the testing in PR #288 |
|
@seanscottking can you rebase this one, too? Thanks! |
Fixes this message `Warning: The key 'certpath' is declared more than once`
|
Looks good, tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'certpath' => $certpathis defined twice, so I removed the second occurrence of it.Fixes this message in puppet logs
Warning: The key 'certpath' is declared more than once